Repository navigation
ci: code sign macOS binaries only when APPLE_NOTARIZE is true - #113
Merged
Merged
Conversation
Releases fail at the certificate import while the Apple certificate is unavailable, even with notarization off.
AI Adoption ReportImportant No AI attribution was found for this pull request. Every commit is missing its
Per-commit breakdown (1 commits)
Warning The following commits have no Git AI authorship notes — AI adoption cannot be tracked for these changes.
Powered by Git AI Standard v3.0.0 — authorship data from |
ealogar
approved these changes
Nov 16, 2026
mdellavedova
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases fail at "Import codesign cert" while the Apple certificate is unavailable, even with notarization off. Code signing now runs only when
APPLE_NOTARIZEistrue; otherwise darwin/arm64 keeps the ad-hoc signature from Go's linker.Tested:
actionlinton both workflows,go test ./internal/selfupdate/ ./test/releasecompat/, andmake build-allwithcodesign -dv dist/vcr_darwin_arm64reportingSignature=adhoc.