Skip to content

ci: code sign macOS binaries only when APPLE_NOTARIZE is true - #113

Merged
sichan-vonage merged 1 commit into
mainfrom
feature/codesign-only-with-notarization
Nov 16, 2026
Merged

sichan-vonage merged 1 commit into
mainfrom
feature/codesign-only-with-notarization

Conversation

@sichan-vonage

Copy link
Copy Markdown
Contributor

Releases fail at "Import codesign cert" while the Apple certificate is unavailable, even with notarization off. Code signing now runs only when APPLE_NOTARIZE is true; otherwise darwin/arm64 keeps the ad-hoc signature from Go's linker.

Tested: actionlint on both workflows, go test ./internal/selfupdate/ ./test/releasecompat/, and make build-all with codesign -dv dist/vcr_darwin_arm64 reporting Signature=adhoc.

Releases fail at the certificate import while the Apple certificate is unavailable, even with notarization off.
@vonage-ai-assistant

Copy link
Copy Markdown

AI Code: 0%

AI Adoption Report

Important

No AI attribution was found for this pull request. Every commit is missing its refs/notes/ai note, so no AI percentage can be computed. This usually means one of:

  • Kiro was launched outside the repository — notes are only written when the session runs inside the git working tree (#60). Start Kiro from the repo root.
  • A session was resumed with --resume — a resumed session does not re-attach notes to new commits. Start a fresh session for work you want attributed.
  • The branch was squash-merged — squashing leaves the notes on the original commits. Prefer a merge or rebase merge, or declare the attribution on the squash commit with #ai-attribution-NNN.
    If none of these apply and git-ai is not yet set up, see the footer below. Per-commit detail is at the end of this report.
Lines %
AI-generated 0 0%
Human 0 100%
Untracked 12 —
Total 12
Per-commit breakdown (1 commits)
Commit Message Added AI Human AI %
3a8c484 ci: code sign macOS binaries only when APPLE_NOTARIZE is tru 12 — — untracked

Warning

The following commits have no Git AI authorship notes — AI adoption cannot be tracked for these changes.
Install git-ai locally (curl -sSL https://usegitai.com/install.sh | bash) to enable automatic tracking.
An automation that cannot run git-ai can declare its own attribution instead, by putting #ai-attribution-NNN in the commit message, where NNN is a whole number from 0 to 100.

  • 3a8c484 ci: code sign macOS binaries only when APPLE_NOTARIZE is tru

Powered by Git AI Standard v3.0.0 — authorship data from refs/notes/ai (supports sessions-v2 format)

@sichan-vonage sichan-vonage added the ai-generated Over 80% AI contribution label Nov 16, 2026
@sichan-vonage
sichan-vonage merged commit 1aa076d into main Nov 16, 2026
29 of 31 checks passed
@sichan-vonage
sichan-vonage deleted the feature/codesign-only-with-notarization branch November 16, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Over 80% AI contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants