Repository navigation
fix(reporting): unblock status webhook bootstrap - #1915
rachitm022 merged 2 commits into
Conversation
There was a problem hiding this comment.
Ladon verdict: Request changes
Request changes — 1 blocking finding.
Blocking findings
- tests/conformance/reporting/test_reporting_status_delivery.py:255 — The new
webhook_signing.supportedgate and the looseneddurable()(emptyreadiness_subscriptionsnow valid) change behavior that breaks the existing conformance testtest_status_capability_requires_each_component_independently_of_activity, which was not updated. Two PostgreSQL-matrix variants (missing=Noneandmissing="signing_probe") will fail in CI though they pass on the in-memory local path. Per "CI gates stay armed," a behavior change that leaves a conformance test red must update the test to match the new intended behavior (or fix the regression).
The rest of the change is coherent: the _project_ready_status_claims projection and the signing gate are fail-closed, and advertised_notifications() is correctly skipped on the unsigned path. Address the broken conformance test and this is good to go.
Blocking findings
- tests/conformance/reporting/test_reporting_status_delivery.py:255 — Behavior change (signing gate + loosened durable()) breaks unupdated conformance test on the PostgreSQL matrix
Superseded by a later Ladon review that rechecked and resolved its blocking findings.
There was a problem hiding this comment.
Ladon verdict: Approve
Approve.
The prior blocking finding has been resolved. The previous run flagged a high finding — a behavior change that broke the unupdated conformance test in tests/conformance/reporting/test_reporting_status_delivery.py:255 (PostgreSQL matrix). This delta updates that test to match the new behavior: it drops the signing_probe variant (empty readiness_subscriptions=() is now valid under the loosened durable()) and adds webhook_signing: {supported: True} to the claim so the expected-case validate_status_claims clears the new signing gate. Error-case variants still raise via ready=False.
No new findings surfaced in this run. The high_risk flag is true only because src/adcp/decisioning/handler.py (modified) matches src/adcp/decisioning/**, but the reviewer found no medium-or-higher concerns on that file, so the modification is presumed safe (does not trigger row 5). No gated paths, no author team gate, no deletions.
Decision table: rows 1–8 do not fire (no critical/high/medium findings, gated_paths false, no deleted high-risk paths, no team gate). Falls through to row 9 — approve. The prior escalate-stickiness rule (row 6) does not apply (prior decision was request-changes, not escalate).
eaa670a to
d000f99
Compare
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — reporting status-notification advertisement reworked with sound, fail-closed logic and no blocking findings.
What I checked:
- Capability now projects only when
webhook_signing.supported is Trueper request; empty-account surface / zero-subscriber bootstrap handled; per-account signing-probe prerequisite dropped while per-subscription validation stays strict (malformed active subscription raisesstatus_subscription_unready). _validate_ready_status_claimsand_project_ready_status_claimsguardsupport is None/isinstancebefore dereferencing;advertisedonly non-empty afterdurable()succeeds sosupport.handleris bound.- Tests cover signed/unsigned discovery, incomplete infra, malformed subscriptions, and empty-surface bootstrap.
High-risk flag: src/adcp/decisioning/handler.py is high-risk (modified), but the reviewer surfaced no medium-or-higher concern on it, so the modification is presumed safe — not an escalation trigger on the flag alone.
Gated paths: false. review_decision is APPROVED. No no-auto-approve team match.
No Critical/High/Medium findings. Rows 1–8 do not fire → row 9 approve.
Non-blocking follow-up (out of delta scope, no finding filed): examples/reporting_status_notifications.py:149 calls validate_status_claims whose new contract requires webhook_signing.supported; worth updating the example so adopters copying it set that capability.
Why
Reliable Reporting capability discovery currently requires a pre-existing external status subscriber or synthetic signing probe. That creates a bootstrap cycle: buyers will not enroll status webhooks until the seller advertises them, while the seller cannot advertise until a subscriber already exists.
Linear: AI-21766
What changed
status_notificationper capability request fromReportingStatusSupport.advertised_notifications()only when that request advertiseswebhook_signing.supported=true.Public Python API for ESA
The existing exports and signatures remain source-compatible:
The standard composition root remains:
Minimal ESA wiring:
platformmust truthfully advertisewebhook_signing.supported=truefor the authenticated request. The handler automatically binds the generated decisioning handler and projects the ready status notification claim.Release required by ESA
This is a patch on the 10.x
nextline after10.0.0b18. Release Please will publish it asadcp==10.0.0b19after this PR and the generated release PR are merged. ESA must useadcp==10.0.0b19or later;10.0.0b18does not contain the bootstrap fix. Noadcp-reporting-storageor wire-schema release is required.Verification