Repository navigation
feat(site): seed index and signatures locally - #182
Merged
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 8, 2026
--index-file skipped the Pages index fetch but still backfilled signature lookaside files from Pages, so a build from a checked-out site was not offline. Add --seed-dir to seed the index and the sigs from a local site and skip the Pages backfill.
abn
force-pushed
the
feat/build-site-seed-dir
branch
from
November 8, 2026 15:36
eed8f8b to
10d1d8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #181. Refs #180.
Problem
--index-fileremoved the Pages round trip for the index, butbackfillSignaturesstill fetched<pages-url>/sigsfor every seeded image. A build from a checked-out site was therefore notoffline: it still stalled when Pages was unavailable and emitted one warning per missing signature.
Change
--seed-dir <site-dir>(envAETHERPAK_SEED_DIR) tobuild-site. It seeds the index from<site-dir>/index/staticand the per-image signature tree from<site-dir>/sigs, then skips thePages backfill entirely.
--index-filekeeps its index-only semantics; the two flags are mutually exclusive.key.asc,signing.json) is not copied: the build generates its own.Record signatures and the current key still win over seeded files.
signature-1anywhere.Unsigned builds stay silent.
EvalSymlinks, the lookaside must stayinside the seed site, non-regular files are rejected, and a hardlinked destination is never
truncated.
--seed-dirand--site-dirrebuilds in place.Testing
record signature overrides the seed, and no Pages request is made.
signatures proceeds silently.
key.asc/signing.jsonfrom the seed are not copied.and dry-run behavior.
copyFilehardlink safety andmissingSignatureRefsdedupe, fallback, sha512, and containmentcases.
go test ./...,go vet ./..., andmake lintpass.