Repository navigation
storage: Fixes for FileBasedDirectory - #2206
Merged
Merged
Conversation
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
October 16, 2026 14:27
juergbi
force-pushed
the
jbilleter/filebaseddirectory
branch
2 times, most recently
from
October 20, 2026 10:39
5310ffe to
4f3004c
Compare
A directory symlink will be overwritten in case of overlap in `__import_files_from_directory`. Make sure the corresponding path is added to `overwritten`.
Use the same logic as in `__import_files_from_directory()` to correctly handle symlinks and populate `FileListResult`.
Match the behavior of `CasBasedDirectory`.
juergbi
force-pushed
the
jbilleter/filebaseddirectory
branch
from
November 5, 2026 12:00
4f3004c to
0ac9678
Compare
abderrahim
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvements to match the behavior of
CasBasedDirectory.