Repository navigation
Bump go-sqlite3 to v1.14.53 to fix build warning - #142
Merged
Merged
Conversation
MisterRaindrop
approved these changes
Nov 10, 2026
The build on the ubuntu-26.04 runner prints this warning for each binary and test package that uses go-sqlite3: sqlite3-binding.c: In function 'sqlite3ShadowTableName': warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] go-sqlite3 v1.14.19 includes SQLite 3.44.0. In that SQLite version, sqlite3ShadowTableName() puts the result of strrchr() on a const string into a non-const pointer, and then writes through it. The new glibc on ubuntu-26.04 follows C23, so strrchr() on a const string returns a const pointer, and GCC reports the assignment. SQLite fixed this function in 3.53.0, which go-sqlite3 includes from v1.14.44. Bump to the latest version, v1.14.53 (SQLite 3.54.1). It needs Go 1.21 or later, so the current Go 1.25 toolchain is fine. See: apache#141 Assisted-by: Claude Code Backpatch-through: REL_2_STABLE
tuhaihe
force-pushed
the
bump-go-sqlite3
branch
from
November 10, 2026 10:23
986fd59 to
40ead3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build on the ubuntu-26.04 runner prints this warning for each binary and test package that uses go-sqlite3:
go-sqlite3 v1.14.19 includes SQLite 3.44.0. In that SQLite version,
sqlite3ShadowTableName()puts the result ofstrrchr()on a const string into a non-const pointer, and then writes through it. The new glibc on ubuntu-26.04 follows C23, sostrrchr()on a const string returns a const pointer, and GCC reports the assignment.SQLite fixed this function in 3.53.0, which go-sqlite3 includes from v1.14.44. Bump to the latest version, v1.14.53 (SQLite 3.54.1). It needs Go 1.21 or later, so the current Go 1.25 toolchain is fine.
See: #141
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
closes: #ISSUE_Number
Change logs
Contributor's checklist
Here are some reminders before you submit your pull request: