Skip to content

Make secstorage.service.offering a zone-scoped setting - #14342

Open
winterhazel wants to merge 3 commits into
apache:4.22from
winterhazel:zone-scoped-ssvm-offering
Open

winterhazel wants to merge 3 commits into
apache:4.22from
winterhazel:zone-scoped-ssvm-offering

Conversation

@winterhazel

Copy link
Copy Markdown
Member

Description

This changes the currently global secstorage.service.offering setting into a zone-scoped setting, just like consoleproxy.service.offering.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

Tests are still pending.

@winterhazel

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.43902% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.32%. Comparing base (2974af8) to head (6332a38).
⚠️ Report is 39 commits behind head on 4.22.

Files with missing lines Patch % Lines
.../secondarystorage/SecondaryStorageManagerImpl.java 0.00% 29 Missing ⚠️
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #14342      +/-   ##
============================================
+ Coverage     18.02%   18.32%   +0.29%     
- Complexity    16250    16644     +394     
============================================
  Files          5936     5939       +3     
  Lines        535823   537797    +1974     
  Branches      65612    65934     +322     
============================================
+ Hits          96582    98542    +1960     
+ Misses       428242   428044     -198     
- Partials      10999    11211     +212     
Flag Coverage Δ
uitests 4.08% <ø> (+0.04%) ⬆️
unittests 19.41% <2.43%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19443

@JoaoJandre JoaoJandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLTGM, did not test it

@winterhazel

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19982

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants