Skip to content

Code style cleanups split out of #12500 - #14556

Open
DaanHoogland wants to merge 1 commit into
removeOvmLeftoversfrom
deprecatedHypervisorCleanups
Open

Code style cleanups split out of #12500#14556
DaanHoogland wants to merge 1 commit into
removeOvmLeftoversfrom
deprecatedHypervisorCleanups

code style cleanups in ApiResponseHelper, Upgrade410to420, AffinityGr…

6dcc413
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 10, 2026 in 5m 55s

Quality Gate failed

Failed conditions
1.4% Coverage on New Code (required ≥ 40%)
C Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 1579 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8O_&open=AaGcm-OImtHvmxH3m8O_&pullRequest=14556

Check warning on line 933 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8No&open=AaGcm-OImtHvmxH3m8No&pullRequest=14556

Check warning on line 2498 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8NL&open=AaGcm-OImtHvmxH3m8NL&pullRequest=14556

Check warning on line 2455 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8NH&open=AaGcm-OImtHvmxH3m8NH&pullRequest=14556

Check warning on line 1983 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OL&open=AaGcm-OImtHvmxH3m8OL&pullRequest=14556

Check warning on line 2458 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Oe&open=AaGcm-OImtHvmxH3m8Oe&pullRequest=14556

Check warning on line 1666 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OH&open=AaGcm-OImtHvmxH3m8OH&pullRequest=14556

Check warning on line 2214 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8ON&open=AaGcm-OImtHvmxH3m8ON&pullRequest=14556

Check warning on line 2455 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8PM&open=AaGcm-OImtHvmxH3m8PM&pullRequest=14556

Check warning on line 659 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Or&open=AaGcm-OImtHvmxH3m8Or&pullRequest=14556

Check warning on line 353 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8MU&open=AaGcm-OImtHvmxH3m8MU&pullRequest=14556

Check warning on line 2223 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8PF&open=AaGcm-OImtHvmxH3m8PF&pullRequest=14556

Check warning on line 1612 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8PB&open=AaGcm-OImtHvmxH3m8PB&pullRequest=14556

Check warning on line 1531 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Mk&open=AaGcm-OImtHvmxH3m8Mk&pullRequest=14556

Check warning on line 613 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Oq&open=AaGcm-OImtHvmxH3m8Oq&pullRequest=14556

Check warning on line 1562 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8N9&open=AaGcm-OImtHvmxH3m8N9&pullRequest=14556

Check warning on line 1172 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8O3&open=AaGcm-OImtHvmxH3m8O3&pullRequest=14556

Check warning on line 464 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Nc&open=AaGcm-OImtHvmxH3m8Nc&pullRequest=14556

Check warning on line 1515 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8N5&open=AaGcm-OImtHvmxH3m8N5&pullRequest=14556

Check warning on line 1579 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Mq&open=AaGcm-OImtHvmxH3m8Mq&pullRequest=14556

Check warning on line 351 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Na&open=AaGcm-OImtHvmxH3m8Na&pullRequest=14556

Check warning on line 229 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Oj&open=AaGcm-OImtHvmxH3m8Oj&pullRequest=14556

Check warning on line 2028 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8M6&open=AaGcm-OImtHvmxH3m8M6&pullRequest=14556

Check warning on line 1533 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Ml&open=AaGcm-OImtHvmxH3m8Ml&pullRequest=14556

Check warning on line 1594 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OB&open=AaGcm-OImtHvmxH3m8OB&pullRequest=14556
View more details on SonarQubeCloud