Repository navigation
Conversation
Coverage Report for CI Build 44696511243Coverage increased (+0.02%) to 96.906%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589.
density_sketchandebpps_sketchpreviously shared family ID19, so consumers could not distinguish the two sketches from the family byte alone. Following the cross-language discussion (apache/datasketches-tck#23), EBPPS keeps19and Density adopts23(0x17).Summary of changes
density_sketch::FAMILY_IDto23so both stream and byte-bufferserializeentry points write23.LEGACY_FAMILY_ID(19), while tighteningcheck_header_validityto require only theIS_EMPTYflag bit alongside the Density preamble size (3when empty,6when non-empty). EBPPS images (preamble longs1or5) continue to be rejected.k.23on stream and byte-buffer serialization, round-tripping and upgrading legacy ID-19images (empty, single-item, and estimation mode) to ID23, and rejecting unrelated family IDs, EBPPS headers, and unexpected flag bits.Verification
density_testwith-DGENERATE=ON, verifying all 11 test cases pass and all 12 generateddensity_{float,double}_n*_cpp.sksnapshots emit family byte23.density_testwith-DSANITIZE=address,undefined.