Skip to content

Family: reserve DENSITY(23) - #811

Open
leerho wants to merge 1 commit into
mainfrom
family-density-23
Open

leerho wants to merge 1 commit into
mainfrom
family-density-23

Conversation

@leerho

@leerho leerho commented Nov 20, 2026

Copy link
Copy Markdown
Member

Reserves family ID 23 for the Density Sketch.

apache/datasketches-cpp#590 (merged, closes apache/datasketches-cpp#589) moved the C++ Density Sketch from family ID 19, which it shared with EBPPS, to 23. C++ still reads ID 19 in v1 images. Java has no Density Sketch, but Family is the project-wide list of IDs, so 23 is added here so that no other sketch takes it.

  • Family.DENSITY(23, "DENSITY", 2, 3). The C++ preamble is 3 ints when empty and 6 ints otherwise, which rounds up to 2 and 3 longs.
  • EBPPS(19) is unchanged.
  • FamilyTest checks the ID-to-family and name-to-family lookups for DENSITY, and that ID 19 is still EBPPS.

Full suite: 2,449 tests, 0 failures. javac -Xlint:all -Xdoclint:all,-missing reports nothing in Family.java.

🤖 Generated with Claude Code

C++ moved the Density Sketch from family ID 19, which it shared with
EBPPS, to 23 (ds-cpp #590, closing ds-cpp #589). Reserve the ID in
Java so it is not reused. Java has no Density Sketch; the preamble
sizes, 2 and 3 longs, follow the C++ 3- and 6-int preambles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use family ID 23 for serialized Density sketches

1 participant