Repository navigation
Conversation
C++ moved the Density Sketch from family ID 19, which it shared with EBPPS, to 23 (ds-cpp #590, closing ds-cpp #589). Reserve the ID in Java so it is not reused. Java has no Density Sketch; the preamble sizes, 2 and 3 longs, follow the C++ 3- and 6-int preambles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserves family ID 23 for the Density Sketch.
apache/datasketches-cpp#590 (merged, closes apache/datasketches-cpp#589) moved the C++ Density Sketch from family ID 19, which it shared with EBPPS, to 23. C++ still reads ID 19 in v1 images. Java has no Density Sketch, but
Familyis the project-wide list of IDs, so 23 is added here so that no other sketch takes it.Family.DENSITY(23, "DENSITY", 2, 3). The C++ preamble is 3 ints when empty and 6 ints otherwise, which rounds up to 2 and 3 longs.EBPPS(19)is unchanged.FamilyTestchecks the ID-to-family and name-to-family lookups forDENSITY, and that ID 19 is stillEBPPS.Full suite: 2,449 tests, 0 failures.
javac -Xlint:all -Xdoclint:all,-missingreports nothing inFamily.java.🤖 Generated with Claude Code