Repository navigation
Conversation
infra-e2e #132 (pulled in by the cf589b4 -> 56ac8be bump in #240) makes the http trigger stop after `times` requests. Before it, `times` only decided when the trigger reported its first result, and the requests kept going until the verify phase finished. The basic case's `times: 10` now means 30 seconds of traffic, and the nightly CI failed on 3 of the 4 nights since #240, every time on `metrics linear service_relation_client_cpm`, whose whole 30-minute window came back empty while the other 15 cases passed. `times: -1` (endless, infra-e2e #134) restores the continuous traffic, the same as the live-debugging case.
Member
Author
|
Folded into #242: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly CI on master has failed on 3 of the 4 nights since #240 (1, 2, 3), after 26 green nights before it. Every failure is the same case in
Command Tests:The case's whole 30-minute window comes back empty. The other 15 cases pass.
Cause
#240 bumped
apache/skywalking-infra-e2efromcf589b4to56ac8be. That range includes infra-e2e #132, which makes the http trigger stop aftertimesrequests. Before it,timesonly decided when the trigger reported its first result, and the requests kept going until the verify phase finished. The basic case'stimes: 10withinterval: 3stherefore now means only 30 seconds of traffic (trigger has completed 10 requests and will stop.in the logs). That is not always long enough for the OAP to attribute the consumer's client-side calls to theproviderservice.Fix
times: -1(endless trigger, infra-e2e #134, already in the pinned SHA) restores the continuous traffic. Thelive-debuggingcase already uses it. Test config only, no change to swctl.