Repository navigation
K2GO-554 chore(rootfs): sign official rootfs tarballs in CI - #750
Merged
Merged
Conversation
Add a dormant minisign step to the bake workflow: sign each official dated tarball after the path-traversal gate and self-verify against the committed public key. Promote requires the .minisig when signing is on. Gated by vars.ROOTFS_SIGNING_ENABLED (default off) for a staged rollout; the app-side verifier and activation ship separately.
The pre-sign traversal gate piped tar to grep; under pipefail a tar read error read as "no unsafe member" and the tarball was signed anyway. Capture the listing first and abort on a tar error, then grep the captured output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
k2go_<date>_<tier>_<sha>_<arch>.tar.gzafter the path-traversal bake gate, asserts the prehashed Ed25519 form (tag "ED"), and self-verifies against the committed public key.<tarball>.minisigrides the existing recursive sidecar upload: a per-artifact sidecar, never a pointer..minisigin lockstep. A publish consistency step checks every published pointer resolves to a signed tarball.promote-rootfs.shrequires the.minisigwhen signing is on (REQUIRE_SIG, set from the variable).controller/rootfs-signing.pub(key idC5E45B250781C960), document verification incontroller/README.md, and add the design ADR.Why
Verifications
bash -non the promote script;yaml.safe_loadon both workflows; ASCII-clean on all files.tarcannot list before signing.vars.ROOTFS_SIGNING_ENABLED(default off), so PR1 merges inert. Activation is a one-switch variable change, after the app-side verifier ships to every channel (BC4).Notes