Repository navigation
K2GO-557 feat(dashboard): in-app update alerts (low-memory gate, failure dialog) - #751
Merged
Merged
Conversation
…ure dialog) Replace the system-notification advisory and failure with in-app UX: a pre-start low-memory gate, a failure dialog, and an app-wide foreground observer that re-shows a pending failure. One flag in UpdateStatusCache is the single source of truth. Low-memory trigger raised to 450 MB from on-device measurement.
Migrate the 8 K2GO-557 UI strings from the untranslated tracker into the 33 locale strings.xml files. Machine-translated, marked for human review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
tools/rebuild-dashboard.sh: on the staging install, reuse the livebetter_sqlite3.nodewhen better-sqlite3 is unchanged, instead of a full node-gyp recompile. Any mismatch (version change, binary does not load, or a new native dep) falls back to compiling from source.sleep 3with a poll up to 45 s (K2GO_REBUILD_STAGE_TIMEOUT), shared with the live verify through onepoll_smokehelper.K2GO_REBUILD_DRYRUN=1) that stops after the staged build and smoke, with no live promote.Why
sleep 3false-failed the staged smoke and aborted the update. The poll absorbs the boot time.Verifications
sleep 3would have false-failed); promote, restart and live verify passed. The reuse path finished in about 4.5 min; the recompile it replaces is about 20 min on this hardware.Notes
tools/rebuild-dashboard.shis the updater, not the dash-node source, so there is no dash-node version bump or changelog entry.