Repository navigation
K2GO-561 fix(clone): stop the Clone hotspot when sharing ends; receive never reaches itself - #752
Merged
Merged
Conversation
…e never reaches itself Clone send stops the Wi-Fi Direct group it started on Stop sharing, on a switch to Wi-Fi and on leaving Clone. A left-up group made a later receive reach its own 192.168.49.1 and slowed Wi-Fi to about 1 MB/s. Clone receive stops the own hotspot and waits until the sender address is not local, as Content Exchange receive does; the local-address check now lives in NetworkInterfaces.
… hotspot Connect, Clone and Content Exchange share acquire and release the shared hotspot; the last release stops it. Replaces the per-feature ownership flags, which a recreated Clone screen lost mid-send.
…er phase postConnecting is async, so the probe thread read IDLE and quit; the receiver stayed on Connecting. Cancel now clears the pending creds instead.
A fixed 2.4 GHz group next to 5 GHz Wi-Fi makes the radio split time: Clone over the hotspot ran at ~3 MB/s. Automatic follows the connected Wi-Fi channel (~44 MB/s). A stored choice is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
LocalHotspotManagerrecords who holds the hotspot (Connect, Clone, Content Exchange share). The lastrelease()stops it. This replaces the per-feature ownership flags.NetworkInterfaces.isLocalAddress.(UI changes: no string added or changed. A new install shows "Automatic" in Settings > Hotspot > Wi-Fi band.)
Why
Verifications
HotspotBandTestpasses.Notes