Skip to content

fix: scope VS Code tooling to Arcscript projects - #25

Merged
panayotisk merged 2 commits into
mainfrom
fix/vscode-csharp-solution
Nov 13, 2026
Merged

panayotisk merged 2 commits into
mainfrom
fix/vscode-csharp-solution

Conversation

@panayotisk

Copy link
Copy Markdown
Collaborator

Opening the repository root lets VS Code discover ANTLR's C# test projects downloaded under Cpp/build, producing GetAntlrJar failures and unsupported .NET 5 warnings. Set dotnet.defaultSolution to CSharp/CSharp.sln so the C# extension opens only the Arcscript solution.

Set cmake.sourceDirectory to ${workspaceFolder}/Cpp so CMake Tools uses the repository's C++ project. Both settings are portable across checkouts. The CMake setting also appears in #24; this PR makes the workspace configuration available independently of enum support.

Validation: parsed the settings as JSON, verified the CMake source directory and the solution's sole project reference, confirmed the installed C# extension supports dotnet.defaultSolution, and ran git diff --check. Applying the C# selection to an existing session requires a VS Code reload; live reload was not tested.

@panayotisk
panayotisk marked this pull request as ready for review November 11, 2026 07:30
Comment thread .vscode/settings.json
@@ -0,0 +1,4 @@
{
"cmake.sourceDirectory": "${workspaceFolder}/Cpp",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also set "cmake.buildDirectory": "${workspaceFolder}/Cpp/build". Changing cmake.sourceDirectory leaves CMake Tools’ default build directory at ${workspaceFolder}/build, so building with the repo root open creates unignored artifacts under <repo>/build. Using Cpp/build keeps editor builds consistent with the documented CLI commands, CI, and existing Git ignore rules.

@Zanzavar Zanzavar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally: generate.sh + configure/build into Cpp/build with ctest 7/7 passing, and CSharp.sln builds with 146/146 tests passing. I also confirmed that Cpp/build contains three ANTLR .sln files the C# extension would otherwise discover.

Nit: the PR description says "both settings", but 4646d97 also adds cmake.buildDirectory. Worth mentioning that it moves CMake Tools' output from the default root build/ (not gitignored) to Cpp/build, which matches Cpp/README.md and the C++ CI workflow.

@panayotisk
panayotisk merged commit 9e13df2 into main Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants