Repository navigation
fix: scope VS Code tooling to Arcscript projects - #25
Conversation
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "cmake.sourceDirectory": "${workspaceFolder}/Cpp", | |||
There was a problem hiding this comment.
Please also set "cmake.buildDirectory": "${workspaceFolder}/Cpp/build". Changing cmake.sourceDirectory leaves CMake Tools’ default build directory at ${workspaceFolder}/build, so building with the repo root open creates unignored artifacts under <repo>/build. Using Cpp/build keeps editor builds consistent with the documented CLI commands, CI, and existing Git ignore rules.
Zanzavar
left a comment
There was a problem hiding this comment.
LGTM. Tested locally: generate.sh + configure/build into Cpp/build with ctest 7/7 passing, and CSharp.sln builds with 146/146 tests passing. I also confirmed that Cpp/build contains three ANTLR .sln files the C# extension would otherwise discover.
Nit: the PR description says "both settings", but 4646d97 also adds cmake.buildDirectory. Worth mentioning that it moves CMake Tools' output from the default root build/ (not gitignored) to Cpp/build, which matches Cpp/README.md and the C++ CI workflow.
Opening the repository root lets VS Code discover ANTLR's C# test projects downloaded under
Cpp/build, producingGetAntlrJarfailures and unsupported .NET 5 warnings. Setdotnet.defaultSolutiontoCSharp/CSharp.slnso the C# extension opens only the Arcscript solution.Set
cmake.sourceDirectoryto${workspaceFolder}/Cppso CMake Tools uses the repository's C++ project. Both settings are portable across checkouts. The CMake setting also appears in #24; this PR makes the workspace configuration available independently of enum support.Validation: parsed the settings as JSON, verified the CMake source directory and the solution's sole project reference, confirmed the installed C# extension supports
dotnet.defaultSolution, and rangit diff --check. Applying the C# selection to an existing session requires a VS Code reload; live reload was not tested.