Skip to content

Remove the live self-test that uses a suspended AWS account - #39

Merged
aebothra-amz merged 1 commit into
aws:mainfrom
aebothra-amz:remove-live-self-test
Nov 13, 2026
Merged

aebothra-amz merged 1 commit into
aws:mainfrom
aebothra-amz:remove-live-self-test

Conversation

@aebothra-amz

Copy link
Copy Markdown
Collaborator

What

The self-test jobs and the CICD demo use arn:aws:iam::048169001733:role/GuruGitHubCICDRole. That account is suspended. The role step fails with "Could not assume role with OIDC: Not authorized to perform sts:AssumeRoleWithWebIdentity". The step has continue-on-error, so the failure is hidden and every CodeGuru step is skipped. The checks are green, but they test nothing (see run 43289397333).

This change:

  • Self-test and release: replaces the 4 live self-test jobs with one "Build and unit test" job (./gradlew clean test installDist distZip) on ubuntu-latest and windows-latest. Pull requests now run the unit tests. Before this change, no workflow ran unit tests on pull requests.
  • Publish Release: now needs the new job. The guards stay the same: it runs only on push to main, and it skips when the tag already exists.
  • Permissions: removes id-token (no OIDC is left). contents is read by default and write only for Publish Release.
  • CICD demo: runs only by hand (workflow_dispatch), has a note that the role must be replaced, and uses CLI 0.2.5. Download and unzip now also skip when the role step fails. A manual run has no commit range (github.event.before and after are empty, and the CLI rejects -c ":"), so the demo passes -c only when both are set and otherwise reviews the whole repository.

No code changes. Main has no required status checks, so the renamed checks do not block merges.

Testing

  • Both workflow files parse as valid YAML.
  • Main has no required status checks (branch protection required_status_checks: contexts [], enforcement off).
  • The unit tests already pass on main in "Build with different JDKs" (run 43289397570).
  • Ran locally on JDK 8 (Corretto 1.8.0_504): ./gradlew clean test installDist distZip, BUILD SUCCESSFUL, 31 tests, 0 failures.
  • This pull request runs the new job on ubuntu-latest and windows-latest.

Follow-ups (not in this PR)

  • java-compatible.yml still uses checkout@v2 and setup-java@v2, and has id-token: write and contents: write. It only builds and tests, so it can drop both.
  • cicd-demo.yml still uses setup-java@v1, configure-aws-credentials@v1 and checkout@v2.

The self-test jobs and the CICD demo assume
arn:aws:iam::048169001733:role/GuruGitHubCICDRole. That account is
suspended, so the role step fails ("Not authorized to perform
sts:AssumeRoleWithWebIdentity"), continue-on-error hides the failure,
and every CodeGuru step is skipped. The checks show green but test
nothing.

- Self-test and release: replace the 4 live self-test jobs with one
  build-and-unit-test job (./gradlew clean test installDist distZip) on
  ubuntu and windows. Pull requests now run the unit tests.
- Publish Release now needs the new job. It keeps its guards: push to
  main only, and skip when the tag already exists.
- Permissions: drop id-token (no OIDC left); contents is read by
  default and write only for Publish Release.
- CICD demo: run only by hand (workflow_dispatch), note that the role
  must be replaced, and use CLI 0.2.5. Download and unzip now also skip
  when the role step fails. A manual run has no commit range, so pass -c
  only when github.event.before and after are set; otherwise review the
  whole repository (the CLI rejects -c ":").
@aebothra-amz
aebothra-amz merged commit d76ae0f into aws:main Nov 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants