Skip to content

BRE2-1285: Warn when API endpoints are overridden - #527

Draft
stephahart wants to merge 1 commit into
mainfrom
steph/BRE2-1285
Draft

stephahart wants to merge 1 commit into
mainfrom
steph/BRE2-1285

Conversation

@stephahart

Copy link
Copy Markdown
Contributor

Warn once during command startup when authentication or API endpoint environment variables point to non-default destinations. Show variable names on stderr without exposing URL credentials, and preserve intentional endpoint overrides.

Validation: CGO_ENABLED=0 go test ./pkg/config ./pkg/cmd -run 'TestWarnEndpointOverrides|TestNewDefaultBrevCommandRegistersGlobalOrgFlag' -timeout 3m passed.

Refs https://linear.app/nvidia/issue/BRE2-1285

@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.06%. Comparing base (6c85c4e) to head (2258344).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
pkg/config/config.go 83.33% 4 Missing ⚠️
pkg/cmd/cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
+ Coverage   33.51%   38.06%   +4.54%     
==========================================
  Files         153      136      -17     
  Lines       21654    20123    -1531     
==========================================
+ Hits         7257     7659     +402     
+ Misses      13624    11668    -1956     
- Partials      773      796      +23     
Flag Coverage Δ
Linux 38.06% <80.00%> (+4.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant