Skip to content

test(apple): distinguish captured focus words from synthetic types - #4087

Merged
thymikee merged 1 commit into
mainfrom
t3/clarify-focus-trait-provenance
Oct 30, 2026
Merged

thymikee merged 1 commit into
mainfrom
t3/clarify-focus-trait-provenance

Conversation

@thymikee

@thymikee thymikee commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Mark the editing and not-editing bridge inputs as rule cases. Their trait words were captured from a SwiftUI TextEditor, but automation type 57 was synthetic in the original focus test. Per-row provenance now records that split explicitly.

One JSON fixture changed. Numeric inputs, expectations, production code and test counts are unchanged. Follow-up to the provenance review of #4073; part of #4045. No live XCTest parity claim.

Validation

Head: 904c91b3aec56d9869ae535a305dedf8815a81f4.

Frozen install/build, full format and all 103 tests across the four producer suites passed. Exact affected validation failed two daemon-entrypoint tests: idle registration remains and startup sweep times out (16,445 passed, two failed, one skipped; run-E3Ovk1, exactCommit: true). Draft pending #4086; unchanged-base full unit passed, but neither failure reproduced, so cause remains unproven. Selected native/replay lanes are CI-owned or parked; local fixture passes do not replace them.

Historical Apple Smoke Tests at 2fbcbb2a2a failed smoke:automation-input while closing the fixture sheet: selector_not_found for automation-close-sheet. That live flow does not consume this fixture; its four readers are unit tests. No infrastructure attribution or smoke-repair claim.

@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
agent-device-website Ready Ready Preview Oct 29, 2026 6:31pm UTC

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.61 MB 5.61 MB 0 B
Package (unpacked) 5.61 MB 5.61 MB 0 B
Package (download) 1.71 MB 1.71 MB +8 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 30.5 ms 27.8 ms -2.7 ms
CLI --help 55.2 ms 55.6 ms +0.4 ms

@thymikee

Copy link
Copy Markdown
Member Author

The change looks good at 904c91b. It only changes a test fixture JSON, with no production code, and all 17 checks are green. There are no conflicts. I did not run the test suite; I judged the change by reading the loader, and I cannot check the #3163 capture source from the repo. Not blocking, take or leave: the new per-row provenance key is not in the fixture type in tree.test.ts, so nothing asserts it and it is free text. You could add provenance?: string to that type and assert it is non-empty for rule rows that carry captured words.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 29, 2026
@thymikee
thymikee marked this pull request as ready for review October 30, 2026 06:55
@thymikee
thymikee merged commit 845b252 into main Oct 30, 2026
20 checks passed
@thymikee
thymikee deleted the t3/clarify-focus-trait-provenance branch October 30, 2026 06:55
@thymikee

Copy link
Copy Markdown
Member Author

On the optional provenance-validation note: I kept the explanatory text outside the decoder's test type. Adding an optional field to a JSON.parse assertion would not validate it at runtime. A non-empty-string assertion would check prose presence, not whether a trait word was captured, and would not detect the original incorrect provenance claim. The executable distinction remains basis: rule; the note explains the mixed captured/synthetic input for human review. No new metadata-only guard or capture-truth claim is added. This PR has since merged; its historical failed local receipt remains attributed to its own head and is not replaced by #4090's later pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant