Repository navigation
Conversation
Checking for __MACH__ is not enough, as that is defined for any OS that uses a (micro)kernel based on Mach (e.g. GNU/Hurd as well). The proper way to check for macOS is using __APPLE__, so adapt the existing branches to check that too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for
__MACH__is not enough, as that is defined for any OS that uses a (micro)kernel based on Mach (e.g. GNU/Hurd as well).The proper way to check for macOS is using
__APPLE__, so adapt the existing branches to check that too.