Repository navigation
Conversation
Contributor
Author
|
@cf-bottom Jenkins with exotics please :) |
Each call to RecordPkgOperationInChroot passed version followed by architecture in the arguments. However, the function signature had this the other way around. To avoid any change in behavior, I changed the parameter names to match the arguments of the call sites. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> (cherry picked from commit d858268)
RecordPkgOperationInChroot() wrote the architecture before the version, the reverse of the order its readers expect. Ticket: none Changelog: Title Signed-off-by: Daniel JB Clark <djbclark@gmail.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit a5a6b6b)
A recorded removal with a version was only reported when it cancelled a recorded installation of the same version. Ticket: none Changelog: Title Signed-off-by: Daniel JB Clark <djbclark@gmail.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit eb6cf5f)
…talls DiffPkgOperations() compared the versions of two recorded installations of the same package without checking that both were set, which PkgVersionIsGreater() asserts. The diff report now keeps the record the way the manifest report does: a versioned record over an unversioned one, otherwise the higher version, otherwise the first one recorded. Ticket: none Changelog: Title Signed-off-by: Daniel JB Clark <djbclark@gmail.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit ab0408f)
larsewi
force-pushed
the
simulate-pkg-fixes-3.24.x
branch
from
November 12, 2026 11:35
5ca3c4f to
a0cd87e
Compare
|
Sure, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/15097/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-15097/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6333, #6389, #6412 and #6424 to 3.24.x.
🤖 Generated with Claude Code