Repository navigation
ENT-14407: Replaced ssh-keyscan with reading host keys in federation setup status - #3237
Merged
craigcomstock merged 1 commit intoNov 9, 2026
Merged
Conversation
larsewi
marked this pull request as draft
November 6, 2026 12:10
larsewi
force-pushed
the
federation-host-keys-from-disk
branch
from
November 6, 2026 12:14
7a9a862 to
821cf38
Compare
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/15016/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-15016/ |
larsewi
marked this pull request as ready for review
November 8, 2026 12:27
craigcomstock
approved these changes
Nov 9, 2026
OpenSSH 9.8+ PerSourcePenalties penalise repeated ssh-keyscan connections from localhost, so the scan often returned nothing and setup status was not written. Host key paths now come from sshd -T and the public keys are read from disk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Ticket: ENT-14407 Changelog: Federation setup status no longer fails to collect the SSH host key fingerprint on OpenSSH 9.8+ Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
craigcomstock
force-pushed
the
federation-host-keys-from-disk
branch
from
November 9, 2026 21:46
821cf38 to
05a2ee0
Compare
nickanderson
approved these changes
Nov 9, 2026
craigcomstock
added
the
cherry-pick?
Contributor
|
Backport to 3.24.x failed, manual backport needed: https://github.com/cfengine/masterfiles/actions/runs/42709316048 |
Contributor
|
Backport to 3.27.x: #3241 |
Contributor
Author
Manual backport #3242 |
larsewi
removed
the
cherry-pick?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSH 9.8+ enables PerSourcePenalties by default. Repeated
ssh-keyscan localhostruns get penalised and return nothing. Federation setup status was then not written, and fr-tests failed on rhel-10, debian-13 and ubuntu-26.04 hubs.The host key paths now come from
sshd -T, and the public keys are read from disk with policy functions. The output format is the same as before:<type> <key>per line, sorted.Generated with Claude Code