Skip to content

fix: Send the CloudQuery registry token only to the exact registry host - #723

Draft
marianogappa wants to merge 2 commits into
mainfrom
fix-docker-token-host-match
Draft

marianogappa wants to merge 2 commits into
mainfrom
fix-docker-token-host-match

Conversation

@marianogappa

Copy link
Copy Markdown
Contributor

The CloudQuery token is now sent on image pull only when the parsed registry host is exactly docker.cloudquery.io, so a look-alike host such as docker.cloudquery.io.example.com no longer receives it.

@marianogappa

Copy link
Copy Markdown
Contributor Author

The TestManagedPluginCloudQueryDocker failure is not from this change: a rerun of the last main unit test job (run 42317994180) fails the same way today with "failed to authorize" on the same image. The CI API key or team secret for that test looks expired or invalid.

kodiakhq Bot pushed a commit that referenced this pull request Nov 13, 2026
…s authenticate (#724)

The CloudQuery registry token is now fetched in-process with the `account` parameter and the `X-Meta-User-Team-Name` and `X-Meta-Plugin-Version` headers and handed to the daemon as a bearer token, because Docker 29's containerd pull path sends neither, which broke `TestManagedPluginCloudQueryDocker` when `ubuntu-latest` moved to ubuntu-26.04 (this predates #723).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants