Repository navigation
Clean up v2 test descriptors and remaining quality findings - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refreshed
masterscan after #16 cleared the original 17 findings and reported four new findings in the descriptor regression tests (#29–32). Make those tests resource-safe even when the operation under test unexpectedly succeeds or fails to close its descriptor.finally, tolerating onlyEBADFbecause successful production cleanup already closes it. Keep the realfstat/EBADFassertion before fallback cleanup.assertRaisesreports the missing exception. Verify the exact injected exception so a cleanup error cannot satisfy the failure expectation.import unittest.mock as mockconsistently withimport unittest, retaining the Python 2 mock fallback.All 137 tests pass locally on Python 3.12;
git diff --checkpasses. Independent review found no actionable defects. All 17 PR checks pass, including Python 2.7 and 3.6–3.15, distributions, Linux integration, CodeQL and Code Quality. Passing PR CI.After merge, default-branch CI and Code Quality analysis pass. Verified the refreshed findings API returns an empty list and the quality dashboard shows 0 maintainability findings and 0 reliability findings, both rated Excellent.