Skip to content

fix: 人工节点选中分支后未提示分支内审批人设定 (#259) - #262

Merged
xlorne merged 1 commit into
devfrom
feature/issue-259-manual-branch-approver-select
Nov 10, 2026
Merged

xlorne merged 1 commit into
devfrom
feature/issue-259-manual-branch-approver-select

Conversation

@xlorne

@xlorne xlorne commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

开始节点提交时只对直接下游节点做 APPROVER_SELECT 判断,人工节点选中分支后
matchNextNodes 返回的是分支节点(MANUAL_BRANCH),分支内的审批人设定节点因而 被漏判:前端不弹选人框,流程直接流转到该节点并因无审批人异常(同 #258 根因)。
改为与审批节点提交路径一致,复用 collectApproverSelectNodes 递归收集,
条件分支仍只沿命中分支、分支节点只看首个节点,兼容 #200 / #231 行为。

Closes #259

开始节点提交时只对直接下游节点做 APPROVER_SELECT 判断,人工节点选中分支后
matchNextNodes 返回的是分支节点(MANUAL_BRANCH),分支内的审批人设定节点因而
被漏判:前端不弹选人框,流程直接流转到该节点并因无审批人异常(同 #258 根因)。
改为与审批节点提交路径一致,复用 collectApproverSelectNodes 递归收集,
条件分支仍只沿命中分支、分支节点只看首个节点,兼容 #200 / #231 行为。

Closes #259
@xlorne
xlorne merged commit 3766d75 into dev Nov 10, 2026
1 check passed
@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.45%. Comparing base (046e83c) to head (bd15fe7).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #262      +/-   ##
============================================
- Coverage     74.49%   74.45%   -0.05%     
+ Complexity     1808     1806       -2     
============================================
  Files           236      236              
  Lines          7485     7484       -1     
  Branches        865      861       -4     
============================================
- Hits           5576     5572       -4     
- Misses         1487     1490       +3     
  Partials        422      422              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xlorne
xlorne deleted the feature/issue-259-manual-branch-approver-select branch November 12, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant