Skip to content

Dev - #263

Merged
xlorne merged 5 commits into
mainfrom
dev
Nov 10, 2026
Merged

Dev#263
xlorne merged 5 commits into
mainfrom
dev

Conversation

@xlorne

@xlorne xlorne commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

删除「禁止自动提交」小节,不再限制未经用户明确要求时的 git commit / push / merge 操作。
开始节点提交时只对直接下游节点做 APPROVER_SELECT 判断,人工节点选中分支后
matchNextNodes 返回的是分支节点(MANUAL_BRANCH),分支内的审批人设定节点因而
被漏判:前端不弹选人框,流程直接流转到该节点并因无审批人异常(同 #258 根因)。
改为与审批节点提交路径一致,复用 collectApproverSelectNodes 递归收集,
条件分支仍只沿命中分支、分支节点只看首个节点,兼容 #200 / #231 行为。

Closes #259
- FlowRecordSaveService:已办结与已撤销记录统一走 removeTodoRecord,合并组只删除本记录的关系并递减合并数量,剩余记录时刷新代表记录
- 删除合并组(组内无剩余记录)时同步清理残余合并关系,避免孤儿数据
- 新增 FlowIssue260MergeRevokeTest:覆盖 a1 撤回后保留 a2、a1 重新提交后合并组恢复为 2 条

Closes #260
…-keep-remaining

fix: 撤回时只摘除自身合并关系,避免误删同组其他流程待办 (#260)
…h-approver-select

fix: 人工节点选中分支后未提示分支内审批人设定 (#259)
@xlorne
xlorne merged commit e6ae481 into main Nov 10, 2026
4 checks passed
@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.45%. Comparing base (f64785e) to head (3766d75).
⚠️ Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
.../codingapi/flow/service/FlowRecordSaveService.java 82.75% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #263      +/-   ##
============================================
- Coverage     74.49%   74.45%   -0.05%     
+ Complexity     1808     1806       -2     
============================================
  Files           236      236              
  Lines          7485     7484       -1     
  Branches        865      861       -4     
============================================
- Hits           5576     5572       -4     
- Misses         1487     1490       +3     
  Partials        422      422              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant