Repository navigation
fix(deps): pgsql-parser 18.3.5 / pgsql-deparser 18.4.5 family - #1998
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found — approved ✅. The change is a coordinated dependency-version refresh of the pgsql-parser toolchain across the monorepo, with no source-code changes. All shared parser deps resolve consistently under the new pins, and
Reviewed commit: caadf88 |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency bump via
npx makage deps ../pgsql-parser --installto pick up tonight's pgsql-parser round-trip fixes (constructive-io/pgsql-parser#378): pretty-mode indentation no longer leaks into multi-line string literals (DEFAULT / CHECK / POLICY / trigger WHEN / ON CONFLICT SET / PL/pgSQL bodies), andA_Indirectionre-parenthesizes compound targets so(ARRAY[1,2,3])[2:3]deparses to valid SQL again.pgsql-parser ^18.3.4 → ^18.3.5,pgsql-deparser ^18.4.4 → ^18.4.5(the fix), plus the matching patch of every other@pgsql/*/plpgsql-parser/pg-proto-parserpublished from the same lerna run.pgsql-deparser@18.4.5/pgsql-parser@18.3.5(was 18.4.4 / 18.3.4 — the buggy pair);pnpm install --frozen-lockfilepasses, lockfile prettier-formatted as usual.Link to Devin session: https://app.devin.ai/sessions/4920ea1178564574884e8f9d5eeaa4fb
Open in Devin Desktop: https://app.devin.ai/desktop/session/4920ea1178564574884e8f9d5eeaa4fb?variant=devin
Requested by: @pyramation
🟢 Devin Review found nothing to fix · View findings