Repository navigation
fix(deps): libpg-query 18.2.4, @pgsql/parser ^1.6.4 - #377
Merged
Merged
Conversation
…rs loadModule fix)
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found — approved ✅. The change is a routine dependency-version alignment across the workspace: all nine package.json files are updated to the same libpg-query patch release (18.2.4), with transform-ast additionally moving its
Reviewed commit: e197bb7 |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings in the fix for libpg-query-node#194 (libpg-query-node#195). Before it,
loadModule({ wasm })threw on Cloudflare Workers withnodejs_compatbecause the Emscripten glue readself.location.href/__dirname. The fix changes only the JS glue: the.wasm, the API and@pgsql/typesare the same, and the dependencies are identical.libpg-query18.2.1→18.2.4in all 9 packages that pin it@pgsql/parser^1.6.2→^1.6.4in@pgsql/transform-astpnpm-lock.yaml(versions + integrity only);pnpm install --frozen-lockfilepasses with itconfig/versions.json(pg13–17 tagged packages) is left alone.Local tests pass:
parser,parse,plpgsql-parser,transform-ast(1443 tests, PG13–17 through@pgsql/parser1.6.4).Link to Devin session: https://app.devin.ai/sessions/8ffe0c4157eb424882da48eb003e5165
Open in Devin Desktop: https://app.devin.ai/desktop/session/8ffe0c4157eb424882da48eb003e5165?variant=devin
Requested by: @pyramation