Skip to content

fix(looks): Save after Stop records the look as Solid - #148

Merged
pyramation merged 1 commit into
mainfrom
devin/1790293515-save-solid-when-stopped
Sep 24, 2026
Merged

pyramation merged 1 commit into
mainfrom
devin/1790293515-save-solid-when-stopped

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

Saving a Look right after the global Stop (blackout) still captured the last-chosen GracePaint animation, because Stop kills the live pattern but not the UI's remembered params. Now saveLook in use-grace-paint.ts checks whether GracePaint is running:

const params = runningRef.current ? p : { ...p, anim: 'still' };  // 'still' = "Solid"

Colours/paint/gradient are kept either way; only the brightness animation falls back to Solid when nothing is playing. UI only.

Link to Devin session: https://app.devin.ai/sessions/c4872c2982734093bdee80d04a7d5ceb
Open in Devin Desktop: https://app.devin.ai/desktop/session/c4872c2982734093bdee80d04a7d5ceb?variant=devin
Requested by: @pyramation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@luxor-code-review

luxor-code-review Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review complete. No issues found — approved ✅.


This small change modifies saveLook in packages/ui/src/lib/use-grace-paint.ts so that when the pattern is stopped (runningRef.current false), the look is persisted with anim: 'still' instead of the live pattern params, keeping the saved look consistent with the stopped visual state. The verification pass found no defects; scan-level candidates about ref staleness and protocol round-tripping did not survive adjudication.

Files Change
packages/ui/src/lib/use-grace-paint.ts saveLook now saves anim: 'still' when the pattern is not running, preserving colors without animation state.

Reviewed commit: 5734ba7

@pyramation
pyramation merged commit 24d3d4d into main Sep 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant