Repository navigation
layout: interleaved-16x2 preset (16 cannons + 16 projectors) + 32-zone routing example - #156
Merged
Merged
Conversation
…one routing example
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found — approved ✅. This PR scales the interleaved cannon/projector layout from 12×2 (24 fixtures) to 16×2 (32 fixtures) for the final Palace rig. The preset is generated by the existing
No high-confidence defects were found; review coverage was complete across all four changed files, including interleaving math, routing-zone mapping, and doc-accuracy checks. Reviewed commit: ce7e9cb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Palace rig is 16 cannons + 16 projectors, not 12 + 12. This adds a named preset for it, keeping
interleaved-12x2:examples/routing-interleaved-16x2.jsoncontains 32 BEYOND routes: C1–C16 on zones 0–15 and P1–P16 on zones 16–31, withzoneBase: 0.No UI change was needed. The canvas already follows the layout's aspect ratio, and Palace and its scene previews already work for any column count. These local screenshots of the 16×2 layout have the panel underneath:
Link to Devin session: https://app.devin.ai/sessions/e6939c79261649988b8277ba34725160
Open in Devin Desktop: https://app.devin.ai/desktop/session/e6939c79261649988b8277ba34725160?variant=devin
Requested by: @pyramation
🟢 Devin Review found nothing to fix · View findings