Repository navigation
Dependencies: Raise urllib3 minimum version to 2.8.0, drop urllib3 1.x - #848
Merged
Merged
Conversation
juanpardo
reviewed
Oct 28, 2026
juanpardo
left a comment
juanpardo
left a comment
There was a problem hiding this comment.
I would also pin certifi because it is also part of the recent vulnerabilities
There was a problem hiding this comment.
Please also consider pinning certifi
Contributor
Author
There was a problem hiding this comment.
Thanks, I pinned the version.
juanpardo
approved these changes
Oct 29, 2026
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Raise the
urllib3requirement from unbounded to>=2.8.0, which removes support for urllib3 1.x.Breaking change: users who pin
urllib3<2.8will get a resolver conflict.Checklist
CHANGES.rstentry