Repository navigation
Add Electrum TLS certificate approvals with adapter 5 timeouts - #1508
Draft
julian-CStack wants to merge 1 commit into
Draft
julian-CStack wants to merge 1 commit into
julian-CStack wants to merge 1 commit into
Conversation
Allow users to review and approve untrusted Electrum certificates per endpoint. Persist approvals, propagate separate primary/failover certificates, and retire connections when approvals change. Guard stale tests and node-form replacement. Integrate electrum_adapter 5.0.0 with bounded setup, subscription lifecycle handling, setup failover, and caller-specific request deadlines. History and broadcast requests default to five minutes; Firo set requests use two minutes. Broadcasts retain existing send/retry behavior with a longer per-attempt deadline. Validation: 246 tests across 36 suites passed. Analysis of 45 changed Dart files found no errors; existing warnings/lint findings remain. All changed Dart files pass formatting checks. Production dependency pins resolved without overrides.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1508 +/- ##
===========================================
+ Coverage 14.01% 15.05% +1.04%
===========================================
Files 1139 1144 +5
Lines 114724 115036 +312
===========================================
+ Hits 16078 17324 +1246
+ Misses 98646 97712 -934 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to review and approve untrusted Electrum certificates per endpoint. Persist approvals, propagate separate primary/failover certificates, and retire connections when approvals change. Guard stale tests and node-form replacement.
Integrate electrum_adapter 5.0.0 with bounded setup, subscription lifecycle handling, setup failover, and caller-specific request deadlines. History and broadcast requests default to five minutes; Firo set requests use two minutes. Broadcasts retain existing send/retry behavior with a longer per-attempt deadline.