[daichirata]

• Fold near-identical tests into tables around shared helpers (142 tests / 3,530 lines → 49 tests / 1,975 lines)
• Inject GCS faults to cover the generation-changed retry, lookup/read errors and the slow-header timeout
• Coverage 95.2% → 96.4%

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

The tests inject malformed GCS error JSON, no longer verify generation pinning, and omit the Content-Length absence check after failed reads, leaving important regressions undetected.

3 open issues

• Use a numeric code in injected GCS error responses · New
• Assert Content-Length is absent after a failed read · New
• Preserve coverage that reads are pinned to the object generation · New

What changed in this PR

This PR consolidates gcsproxy’s tests into shared helpers and table-driven cases, while expanding coverage of storage failures and HTTP timeouts.

Changes:

• Reorganizes routing, headers, ranges, conditional requests, and logging tests.
• Adds fault injection for GCS lookup/read errors and generation-change retries.
• Makes the header timeout adjustable for a slow-header test, retaining the 10-second default.

File	Description
main.go	Changes the header timeout from a constant to a variable for testing.
main_test.go	Consolidates tests and adds fault-injection and timeout coverage.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The revised tests leave retry metadata and precondition re-evaluation unverified and drop error-header, range-validator, and response-body assertions, allowing regressions to pass.

No open issues 🎉

3 resolved since last review

• Preserve coverage that reads are pinned to the object generation
• Assert Content-Length is absent after a failed read
• Use a numeric code in injected GCS error responses

_{Review effort: Balanced}