Repository navigation
Conversation
Signed-off-by: Christopher Maher <chris@mahercode.io>
The README told Foreman users to annotate the six foreman.llmkube.dev CRDs with helm.sh/resource-policy: keep and then helm uninstall the release. helm uninstall reads the resource policy from the manifest stored with the release, not from the live objects, so the annotation alone would not have kept the CRDs or the resources in them. The migration guide takes the CRDs out of the release with a helm upgrade first, which does read the live annotation. Point the README and the docs index at that guide instead of repeating the steps. Signed-off-by: Christopher Maher <chris@mahercode.io>
Signed-off-by: Christopher Maher <chris@mahercode.io>
Signed-off-by: Christopher Maher <chris@mahercode.io>
… migration Signed-off-by: Christopher Maher <chris@mahercode.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
docs/migrating-from-foreman.md, a step-by-step guide for moving a running Foreman install to Meitheal. It also fixes the CRD migration steps in the README, which now point to the guide instead of repeating them, and two stale lines indocs/README.md.Why
Foreman moved out of LLMKube into this repository as Meitheal (defilantech/LLMKube#2526, removal in defilantech/LLMKube#2594). The new API group means new CRDs, so an existing install moves over beside Meitheal rather than upgrading in place. The old chart templates its CRDs without
helm.sh/resource-policy: keep, so getting the order wrong deletes every Agent, AgenticTask, AgentRelease, FleetNode, ModelProfile and Workload.The README's first step was wrong. It said to annotate the CRDs with
keepand then uninstall, buthelm uninstallreads that annotation from the release's stored manifest, not from the live CRD, so the annotation alone doesn't keep them.How
Three commits:
docs: add a migration guide for Foreman users: the guide.helm upgradethe foreman release at its installed chart version with--reuse-values --set crds.install=false, then confirm the CRDs and resources are still there.helm upgradechecks the live annotation before deleting a resource that left the manifest, so this takes the CRDs out of the release without deleting them.meithealchart beside it.foreman, then delete the old CRDs explicitly.--reuse-valuescarriescrds.install=falseinto exported values, so the install sets it back to true.agentKindisforeman-agentare dropped, and the rest come back withapproved: false.kubectl create, neverapply, and the git credentials Secret's default name changed.meitheal-coderservice account and image.docs: fix the Foreman CRD migration steps: the README's migration section now explains why annotating alone fails and links the guide.docs/README.mdlinks it too.docs: file issues in the Meitheal repo and fix the docs logo path: "Where to file issues" pointed at defilantech/LLMKube, and the logo path indocs/README.mdwent one directory too high.The Helm behavior was checked against Helm's source (
pkg/action/uninstall.goreads the stored manifest;pkg/kube/client.gore-reads the live object on upgrade). The jq filters were run against test objects. I haven't run the full sequence against a live Foreman release yet.meitheal.dev (defilantech/meitheal-web) renders this guide in its docs once this merges.
Checklist
make testpasses locallymake lintpasses locallygit commit -s) per DCO