Repository navigation
Conversation
There was a problem hiding this comment.
Codra Review
✅ Nothing to flag. Reviewed 8 files (266 changed lines) and found no issues worth raising.
Reviewed commit: c73f7144e4
ℹ️ About Codra in GitHub
Your team has set up Codra to review pull requests in this repo. Reviews are triggered when you:
- Open a pull request for review
- Mark a draft as ready
Every review posts a summary here. A clean pass also gets a 👍 on the pull request itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #184.
@playwright/test(pinned to 1.65.1) and keeps browser tests in a separateplaywright/directory so Vitest's existing JSDOM suite is unchanged.baseURL: http://localhost:3000, browser artifact output, and awebServerlauncher for Codra's Node server..env.e2e.exampleand launcher that loads the isolated test environment, generates a throwaway GitHub App key, disables the review worker and telemetry, and starts the Node dev server.npm run test:e2escript, ignores Playwright artifacts, and documents the disposable PostgreSQL/Redis setup.Validation
node --checkagainst the E2E server launcher successfully.npm run test:e2e.The smoke test does not require database migrations or seeded rows. PostgreSQL and Redis are isolated local services so the real Node runtime can start with test-only settings.