Repository navigation
Raise minimum versions of js-yaml, tar and shell-quote - #1348
Open
An Nguyen (annguyens) wants to merge 1 commit into
Open
An Nguyen (annguyens) wants to merge 1 commit into
An Nguyen (annguyens) wants to merge 1 commit into
Conversation
Lockfile already resolves the patched versions; this raises the declared ranges so they no longer admit versions affected by GHSA-h67p-54hq-rp68, GHSA-2883-xcg3-v3hh, GHSA-52cp-r559-cp3m, GHSA-5p4m-2wfm-xmqj (js-yaml), GHSA-8x88-c5mf-7j5w, GHSA-23hp-3jrh-7fpw, GHSA-r292-9mhp-454m, GHSA-w8wr-v893-vjvp, GHSA-gvwx-54wh-qm9j (tar), GHSA-395f-4hp3-45gv, GHSA-w7jw-789q-3m8p (shell-quote). Co-Authored-By: Claude Code
Author
|
@microsoft-github-policy-service agree company="Capital One Services, LLC" |
Author
|
Hi Christof Marti (@chrmarti) can I have a review on this? This PR only raises the declared lower bounds to the versions yarn.lock already resolves, so the build output is unchanged. Happy to adjust if you'd prefer a different approach! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the declared ranges for three runtime dependencies so they no longer admit versions affected by published advisories:
js-yaml^4.1.1→^4.3.2tar^7.5.10→^7.5.21shell-quote^1.8.3→^1.11.0yarn.lockalready resolves these exact versions (from the earlier Dependabot bumps #1292, #1329, #1337), so only the lockfile key lines change. Resolved versions and integrity hashes are unchanged, and the bundled CLI output is the same. This just stops the manifest from advertising vulnerable lower bounds to scanners and to anyone resolving the ranges without the lockfile.Verified locally:
yarn install --frozen-lockfilelockfile check,tsc -b,eslint --max-warnings 0 ./src, andsrc/test/dockerComposeUtils.test.ts.Co-Authored-By: Claude Code