Skip to content

[node] - Fallback to older logic when version-resolution helper doesn't exist - #1773

Open
Kaniska (v-Kaniska244) wants to merge 1 commit into
devcontainers:mainfrom
v-Kaniska244:node-feature-fallback-check
Open

Kaniska (v-Kaniska244) wants to merge 1 commit into
devcontainers:mainfrom
v-Kaniska244:node-feature-fallback-check

Conversation

@v-Kaniska244

@v-Kaniska244 Kaniska (v-Kaniska244) commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes standalone copies of the Node installer failing when scripts/version-resolution.sh is missing, as reported with npm-based features in devcontainers-extra/features.

Validation

  • All 138 version-resolution assertions passed.
  • Bash syntax and whitespace checks passed.
  • Confirmed the regression harness reproduces the original missing-helper failure.
  • ShellCheck was unavailable locally.

@v-Kaniska244 Kaniska (v-Kaniska244) changed the title [node] - Fallack to older logic when version-resolution helper doesn't exist [node] - Fallback to older logic when version-resolution helper doesn't exist Nov 12, 2026
@v-Kaniska244
Kaniska (v-Kaniska244) marked this pull request as ready for review November 12, 2026 10:24
@v-Kaniska244
Kaniska (v-Kaniska244) requested a review from a team as a code owner November 12, 2026 10:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant