Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3106 +/- ##
==========================================
- Coverage 84.44% 84.35% -0.10%
==========================================
Files 260 260
Lines 58782 59083 +301
Branches 4989 4996 +7
==========================================
+ Hits 49640 49837 +197
- Misses 8314 8416 +102
- Partials 828 830 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mloubout
force-pushed
the
subsampling-blocking-mpi
branch
from
November 6, 2026 23:03
43c9548 to
7144885
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
force-pushed
the
subsampling-blocking-mpi
branch
from
November 7, 2026 02:24
4722b62 to
9604a82
Compare
mloubout
force-pushed
the
subsampling-blocking-mpi
branch
3 times, most recently
from
November 9, 2026 05:16
3dfea40 to
f2d69b0
Compare
Blocking replaced the iteration Dimensions, which degraded a GuardFactor to a plain CondEq and left blocked Dimensions guarded. Run `subsampling` before `_specialize_clusters` instead, so that tiles span the subsampled Dimensions. Under MPI a SubGrid applied its factor to rank-local indices, so a rank not starting on a subsampled point read the wrong parent points. Give ConditionalDimension an `offset`, the intercept of its map onto the parent, through a SubsamplingOffset symbol localized by MPI like a Thickness. Decompose a SubGrid through SubGridDistributor, so that a rank owns exactly the points lying on its own parent points, and derive the subsampled bounds from the parent's rank-local ones, which stops strided loops overrunning a rank.
A bare Dimension in an expression compiled to the rank-local loop index, so Eq(u, x + y) restarted from zero on each MPI rank. Offset it by the new Grid.origin_isymbols, passed like origin_symbols. Dimensions indexing a Function stay rank-local, and the code generated without MPI is unchanged. Fixes #2214
mloubout
force-pushed
the
subsampling-blocking-mpi
branch
from
November 9, 2026 12:46
f2d69b0 to
be58bf3
Compare
With subdomain=, a Function on a SubGrid kept iterating its whole subsampled Dimension around the SubDomain loop, so every point accumulated over the entire SubDomain. Subsample the SubDomain's Dimension instead, bound it by the parent's actual extent, thickness included, and localize the thicknesses that only bound such a Dimension. Also keep time guarded in the subsampling pass: it now runs before cluster specialization, where buffering and other time-based lowering rely upon the guard.
mloubout
force-pushed
the
subsampling-blocking-mpi
branch
from
November 9, 2026 14:08
be58bf3 to
6a7093f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix blocking with strided subdim.
Fix MPI subdim start point
Fix Dimensions used as expressions under MPI, e.g.
Eq(u, x + y).Fixes #2214