Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
==========================================
- Coverage 84.44% 84.41% -0.03%
==========================================
Files 260 260
Lines 58782 58806 +24
Branches 4989 4989
==========================================
+ Hits 49640 49644 +4
- Misses 8314 8335 +21
+ Partials 828 827 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| f = alias or self.target.c0 | ||
| neighborhood = f.grid.distributor.neighborhood | ||
|
|
||
| # The ranks are taken from the `nb` provided at runtime by the (possibly |
There was a problem hiding this comment.
are u sure that the proper fix ain't in _arg_values? _arg_values is where u should pull the override
see for example MPIMsg._arg_values
| # The ranks are taken from the `nb` provided at runtime by the (possibly | ||
| # overriding) Grid or SubDomain, as `f` may be a compiler-generated Array | ||
| # still attached to the Grid the Operator was built with | ||
| nb = f.grid.distributor._obj_neighborhood |
There was a problem hiding this comment.
I still don't get why not args.grid, the grid is supposed to be unique to the operator.
| # The ranks are taken from the `nb` provided at runtime by the (possibly | ||
| # overriding) Grid or SubDomain, as `f` may be a compiler-generated Array | ||
| # still attached to the Grid the Operator was built with | ||
| nb = f.grid.distributor._obj_neighborhood |
There was a problem hiding this comment.
this whole thing looks like it's doing what nb._arg_defaults should be doing by hand
There was a problem hiding this comment.
seconded (related to what I wrote above)
Previous merge broke some decoupler tests in PRO due to compiler-generated arrays taking their neighbouring ranks from the
Gridwith which they were built rather than the one supplied at apply time. This specifically appeared indiag2/overlap2/fullmode.