Repository navigation
test: make three timing-dependent tests deterministic - #525
Merged
Merged
Conversation
The thread making the native calls deferred from a callback could make them before the test checked that they had not been made yet.
Both waits took 100 ms: a close() that woke up late found closing ended and reported no timeout.
A handler sleeping 200 ms per frame fell behind only where the encoder sent more than about five frames a second, which slow runners did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tests that failed now and then on CI runners, independent of recent changes:
SinkRegistryTests: the deferred sink changes are held until the test has checked that they were not made yet.RuntimeCloseTests.closeTimeoutReported: the runtime close ends only afterclose()has timed out; both waited 100 ms.MediaTests.slowFrameHandlerGetsNewest: the handler blocks until the decoder got ahead, instead of relying on more than about five frames a second.