Skip to content

feat: update the grammar of diffpy macro - #69

Open
ycexiao wants to merge 4 commits into
diffpy:mainfrom
ycexiao:macro
Open

ycexiao wants to merge 4 commits into
diffpy:mainfrom
ycexiao:macro

Conversation

@ycexiao

@ycexiao ycexiao commented Nov 15, 2026

Copy link
Copy Markdown
Contributor
  • feat: update macro grammar in accordance with MCP
  • docs: update the runmacro documentation
  • chore: add news

What problem does this PR address?

Update the grammar of diffpy macro, and remove deprecated pdfadapter.

What should the reviewer(s) do?

@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.52%. Comparing base (2ed464d) to head (94f385a).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_runmacro.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   99.69%   99.52%   -0.18%     
==========================================
  Files           8        7       -1     
  Lines         666      633      -33     
==========================================
- Hits          664      630      -34     
- Misses          2        3       +1     
Files with missing lines Coverage Δ
tests/test_runmacro.py 96.42% <96.00%> (-3.58%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ycexiao
ycexiao marked this pull request as ready for review November 15, 2026 02:21
@ycexiao

ycexiao commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge it's ready for review. The codcov check didn't pass because I removed both pdfadapter.py and test_pdfadapter.py

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant