Repository navigation
test: use vector tolerance instead of abs value and fix symbol export checks failed in macos and windows - #77
Merged
Merged
Conversation
Release builds use -ffast-math, with LTO and FMA the inlined Lattice::cartesian in the bond generator can round differently from the out-of-line one the reference calls. This failed the exact comparison on macOS arm64. Use EpsilonEqual like the other tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dumpbin /disasm prints no function labels for objects and the cctools nm of the conda macOS compilers rejects the GNU options. llvm-nm and llvm-objdump read ELF, Mach-O and COFF alike, install them in the CI environment and use them on all platforms. Save the kernel objects when the check fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@sbillinge PR ready for review. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 87.03% 87.04% +0.01%
==========================================
Files 147 147
Lines 8377 8376 -1
Branches 2060 2059 -1
==========================================
Hits 7291 7291
+ Misses 629 628 -1
Partials 457 457
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #76's matrix failure, this PR:
nmsymbol checks with the more universalllvm-nmones so that calling conventions work on all platforms.Matrix results https://github.com/SYMSCAE/libdiffpy/actions/runs/43551510428/job/132314796109