Repository navigation
nanobind: LSQ.PrepareRefParList() is verbose by default #129
Description
After #116 lsq.PrepareRefParList should be silent by default. But with nanobind, if called with only one argument lsq.PrepareRefParList(copy_param=False) it resolves to the one-argument overload which is verbose, contrary to the docstring.
from pyobjcryst.crystal import Crystal
from pyobjcryst.lsq import LSQ
c1 = Crystal(4.0, 5.0, 6.0, "P1")
c2 = Crystal(4.0, 5.0, 6.0, "P1")
lsq = LSQ()
lsq.SetRefinedObj(c1, 0, True, False)
lsq.SetRefinedObj(c2, 0, False, False)
# should be silent but isn't
print("### PrepareRefParList(copy_param=False)")
lsq.PrepareRefParList(copy_param=False)
# is silent
print("### PrepareRefParList(copy_param=False, verbose=False)")
lsq.PrepareRefParList(copy_param=False, verbose=False)gives
### PrepareRefParList(copy_param=False)
WARNING: RefinableObj::AddPar(..., copyParam=false): parameter name 'a' is not unique, appending address suffix.
WARNING: RefinableObj::AddPar(..., copyParam=false): parameter name 'b' is not unique, appending address suffix.
WARNING: RefinableObj::AddPar(..., copyParam=false): parameter name 'c' is not unique, appending address suffix.
WARNING: RefinableObj::AddPar(..., copyParam=false): parameter name 'alpha' is not unique, appending address suffix.
WARNING: RefinableObj::AddPar(..., copyParam=false): parameter name 'beta' is not unique, appending address suffix.
WARNING: RefinableObj::AddPar(..., copyParam=false): parameter name 'gamma' is not unique, appending address suffix.
### PrepareRefParList(copy_param=False, verbose=False)
Activity
[-]nanobind: `LSQ.PrepareRefParList()` is verbose by default, unlike on main[/-][+]nanobind: `LSQ.PrepareRefParList()` is verbose by default[/+]sbillinge commentedon Nov 14, 2026
closed by #130