Repository navigation
Conversation
nanobind has no global converter for CrystVector_REAL/CrystMatrix_REAL, so bindings that returned them directly raised when called. Wrap them in crystvec_to_array/crystmat_to_array: - UnitCell.GetLatticePar(), UnitCell.GetOrthonormalCoords() - Crystal.GetMinDistanceTable() - ScatteringPower.GetScatteringFactor(), GetTemperatureFactor(), GetResonantScattFactReal(), GetResonantScattFactImag(), (both in the base binding and in the forwarding for ScatteringPowerAtom and GlobalScatteringPower) Add tests that call each method, plus a check that no binding's signature still returns a raw CrystVector/CrystMatrix. fixes diffpy#127
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nanobind_migration_test #128 +/- ##
==========================================================
Coverage ? 98.78%
==========================================================
Files ? 22
Lines ? 2312
Branches ? 0
==========================================================
Hits ? 2284
Misses ? 28
Partials ? 0
🚀 New features to boost your workflow:
|
sbillinge
merged commit Nov 14, 2026
c2df30c
into
diffpy:nanobind_migration_test
8 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nanobind has no global converter for CrystVector_REAL/CrystMatrix_REAL, so bindings that returned them directly raised when called.
Wrap them in crystvec_to_array/crystmat_to_array:
Add tests that call each method, plus a check that no binding's signature still returns a raw CrystVector/CrystMatrix.
fixes #127