Repository navigation
test: check that the smoke test's scheduled run succeeds - #60
Merged
Merged
Conversation
The check only looked for a START line, so a failing scheduled run passed. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The smoke test's "scheduled invocation ran" check only looked for a
STARTline in the function's logs, so it passed even though every scheduled run failed: a scheduled run calls the handler with no arguments, andparity(number)has no default.parity.Rthat givesnumbera default of 2.inst/parity.Ris unchanged, since the README uses it to show why scheduled handlers need defaults.REPORTline, the test fails if the run logged anERRORline (lambdr logs a failed run withlogger::log_error()). A failed log query fails the check instead of passing it.nextTokenthrough a sharedlog_events()helper, also used to save the logs.Related GitHub Issues and PRs
Are these changes tested?
Not yet against AWS: this changes
dev/smoke-test.R, which needsRscript dev/smoke-test.Rto run. The script parses and passesjarl.Are there any user-facing changes?
No.
Was AI used for this PR?
In accordance with the AI generation guidelines, please disclose whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
Checklist
fix:,feat:,docs:, ...); it becomes theNEWS.mdentry.air format .andjarl check ..devtools::document()if documentation changed.testthatunit tests totests/testthatfor any new functionality or fixed bug.Assisted-by: Claude Code