Repository navigation
Conversation
The CLI flushes traces and metrics at exit with a 50ms timeout (ExportTimeout). The OTLP gRPC exporters were created with the default retry policy, so when the endpoint refuses the connection the export keeps backing off until the timeout expires instead of returning. This happens on every command when the current context points at a unix socket that has no listener, for example Docker Desktop's context while Desktop is not running, which leaves its analytics socket file behind. A retry cannot complete within 50ms anyway, so turn retries off. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CLI exports traces and metrics at exit with a 50ms budget (
ExportTimeout). The OTLP gRPC exporters are created with the default retry policy, so when the endpoint refuses the connection the export backs off until the whole budget is used instead of failing right away. This happens on every command,docker --versionincluded.A common case is Docker Desktop's
desktop-linuxcontext while Desktop is not running: its metadata pointsOTEL_EXPORTER_OTLP_ENDPOINTat a unix socket that still exists as a file but has no listener. On Windows, Desktop leaves%LOCALAPPDATA%\Docker\run\userAnalyticsOtlpHttp.sockbehind.This passes
WithRetry(RetryConfig{Enabled: false})to both exporters. A retry cannot complete within 50ms anyway, so the only change is that a failed export gives up sooner.To verify: with the Desktop context selected and Desktop stopped, time
docker --version. Built from master (7c0f1b2) with and without this change (Go 1.27.3, CGO off), 30 interleaved runs, median of paired differences with 95% confidence interval:On v29.9.2 with 40 runs the same change gave -45.4 ms (44.0 to 46.1) on Windows and -50.0 ms (48.9 to 51.1) on Linux. With the default context it makes no difference.
go test ./cli/command/... ./cli-plugins/...passes on Linux.I used an AI assistant (GitHub Copilot) for the investigation and to help write this change; I reviewed and tested it.
Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)