Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for this documentation-only clarification of compaction behavior and toolset environment precedence.
No open issues 🎉
What changed in this PR
This documentation-only PR clarifies existing compaction behavior and toolset environment precedence in docker-agent.
Changes:
- Documents per-session compaction exclusivity, concurrent-request errors, proactive-compaction warnings, and retry guidance.
- Clarifies that MCP and LSP toolset
envvalues override matching variables inherited from the host.
| File | Description |
|---|---|
docs/tools/mcp/index.md |
Explains host environment inheritance and toolset env precedence. |
docs/tools/lsp/index.md |
Clarifies that toolset env overrides host values. |
docs/guides/compaction/index.md |
Documents concurrent-compaction handling and retry guidance. |
Review effort: Balanced
trungutt
previously approved these changes
Oct 30, 2026
aheritier
force-pushed
the
docs/auto-update
branch
from
October 31, 2026 05:01
2f5eacf to
036a9a7
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Code Mode warning still gives incorrect delegation configuration advice and needs to distinguish supported direct delegation from unsupported calls inside scripts while retaining the permission-granularity warning.
1 open issue
Review effort: Balanced
trungutt
previously approved these changes
Oct 31, 2026
rumpl
reviewed
Oct 31, 2026
|
|
||
| From `/context`, select any live session with the arrow keys and press <kbd>Enter</kbd> to explicitly compact it — including a sub-agent's session, not just the main one. This is the only way cross-agent compaction happens: there's no idle-triggered automatic compaction of sub-agent sessions, so a long-running background agent stays under your control. The request is queued onto the target session's own run loop and applied at the next safe point between model turns, so it never corrupts an in-flight turn. | ||
|
|
||
| Only one compaction runs per session at a time. If a compaction is already in progress — including a background one — a manual `/compact`, an explicit compaction from `/context`, or an overflow-recovery compaction is rejected with a `compaction already in progress` error rather than sending a second summarization request. A proactive threshold compaction that is skipped for the same reason surfaces as a warning. Retry once the running compaction finishes. |
Member
There was a problem hiding this comment.
Too much details about the internals here, remove
- code-mode: fix approval warning to reflect that handoff/transfer_task stay directly callable (Copilot review comment) - compaction: remove internals-level paragraph on concurrent compaction (rumpl review comment)
aheritier
enabled auto-merge
October 31, 2026 11:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation changes
docs/guides/compaction/index.md): documents that only one compaction runs per session at a time; concurrent manual,/context, or overflow-recovery compactions are rejected withcompaction already in progress.docs/tools/mcp/index.md) and LSP toolset (docs/tools/lsp/index.md): clarify that the toolset'senvtakes precedence over the inherited host environment.docs/features/code-mode/index.md): notes that runtime-handled tools (transfer_task,handoff,run_skill, background-agent tools) stay directly callable and are not wrapped into the script.Source PRs
Other PRs merged in the last 36h needed no doc changes.