Skip to content

Bug fix omnibus: issues #381 #380 #352 #378 #376 #295 #106 #297 #322 #126 #379 #159 #259/#360 - #396

Open
robert-d-schultz wants to merge 14 commits into
donkeyProgramming:masterfrom
robert-d-schultz:vibecoded-bug-fix-omnibus
Open

robert-d-schultz wants to merge 14 commits into
donkeyProgramming:masterfrom
robert-d-schultz:vibecoded-bug-fix-omnibus

Conversation

@robert-d-schultz

Copy link
Copy Markdown
Collaborator

A batch of fixes and small features from the open issues. One commit per issue, so each can be reviewed (or dropped) on its own.

Bug fixes

Features

Already fixed on master, can be closed

Not in this PR

Testing

The full solution builds and all tests pass. The UI changes haven't been tested by hand, and nothing has been tested in-game.

🤖 Generated with Claude Code

robert-d-schultz and others added 14 commits November 17, 2026 17:43
…nkeyProgramming#381)

OpenWebpageCommand went through 'cmd /c start', which split local paths
on spaces. Launch via the shell directly instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Editable pack -> active project, PackFile Explorer -> File Explorer,
Current Game -> Current game, Show CA audio (.wem) files -> Show WEM files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…g#352)

The combobox used WPF's prefix-only TextSearch. Bind its text to the
FilterCollection filter like other filterable comboboxes, with a plain
substring match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rogramming#378, donkeyProgramming#376)

Double-clicking a sound or music track node loads and plays it. When the
WEM a node refers to is not in the loaded files, the data panel says so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TrimStart("//skeleton//".ToCharArray()) also stripped leading letters
from the set /skeleton, so 'snake01' became 'ake01'. Strip the prefix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QuaternionToEulerDegree returned (rotation about Y, about Z, about X) and
EulerDegreesToQuaternion read it the same way, so the meta-data editor
(e.g. ANIMATED_PROP orientation) and skeleton editor showed axes under
the wrong labels: a value typed into Z became a rotation about X. Both
helpers now use X/Y/Z = rotation about X/Y/Z. Rotation order unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…onkeyProgramming#297)

SoundBankGeneratorService built its hirc generator factory in the
constructor, so opening the Audio Editor with e.g. a non-WH3 game
selected threw 'Unknown Bank Generator Version: 0'. Create it on first
use and give a readable error when generating for an unsupported game.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The geometry/material/LOD strategy and 'only save visible' choices made
in the save dialog are stored per game in the application settings and
used as the starting point for the next model saved, including in new
editors and after a restart. Per-model values (output name, LOD count)
still come from the model.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Routes the remaining Console.WriteLine calls in app code through the
Serilog logger: per-frame bone/gizmo/selection traces at Debug, report
printers and the scene graph dump at Information. Left as-is: the
MeshDecimator ConsoleLogger (it is a console logger by design) and the
Music end-to-end dev runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Right-click a sound or music track node in the tree to export its audio
as a 16-bit PCM .wav or the raw .wem. Right-click now also selects the
node under the mouse so the menu acts on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A one-frame clip was written as one dynamic frame and no static frame,
which crashes the game. Surveyed ~1,600 vanilla WH3 anims: none has
exactly one dynamic frame. Poses (docking, faces, hand poses, pose/) are
static frame only, zero dynamic frames, 0.1s, in both v7 and v8. Write
one-frame clips the same way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ming#259, donkeyProgramming#360)

PFH6 index entries have the same is_compressed byte as PFH5 (RPFM reads
it for both; confirmed on CA's own PFH6 _.pack from Pharaoh Dynasties).
AE only read it for PFH5, so every entry in a PFH6 pack after the first
was a byte off: garbage names, sizes and offsets. Likely cause of the
Pharaoh cosmetic DLC models failing with 'Unknown Lod header' (garbage
bytes reaching the RMV parser) and 'Unable to read beyond the end of the
stream' (offsets past the end of the pack).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…egex

FilterCollection built a regex before calling the custom substring
filter, so a half-typed "Play_x (wh3" threw, marked the box invalid and
stopped the list updating. Add an opt-in plain-text mode that skips it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment