Repository navigation
Bug fix omnibus: issues #381 #380 #352 #378 #376 #295 #106 #297 #322 #126 #379 #159 #259/#360 - #396
Open
robert-d-schultz wants to merge 14 commits into
Open
robert-d-schultz wants to merge 14 commits into
robert-d-schultz wants to merge 14 commits into
Conversation
…nkeyProgramming#381) OpenWebpageCommand went through 'cmd /c start', which split local paths on spaces. Launch via the shell directly instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Editable pack -> active project, PackFile Explorer -> File Explorer, Current Game -> Current game, Show CA audio (.wem) files -> Show WEM files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…g#352) The combobox used WPF's prefix-only TextSearch. Bind its text to the FilterCollection filter like other filterable comboboxes, with a plain substring match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rogramming#378, donkeyProgramming#376) Double-clicking a sound or music track node loads and plays it. When the WEM a node refers to is not in the loaded files, the data panel says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TrimStart("//skeleton//".ToCharArray()) also stripped leading letters
from the set /skeleton, so 'snake01' became 'ake01'. Strip the prefix.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QuaternionToEulerDegree returned (rotation about Y, about Z, about X) and EulerDegreesToQuaternion read it the same way, so the meta-data editor (e.g. ANIMATED_PROP orientation) and skeleton editor showed axes under the wrong labels: a value typed into Z became a rotation about X. Both helpers now use X/Y/Z = rotation about X/Y/Z. Rotation order unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…onkeyProgramming#297) SoundBankGeneratorService built its hirc generator factory in the constructor, so opening the Audio Editor with e.g. a non-WH3 game selected threw 'Unknown Bank Generator Version: 0'. Create it on first use and give a readable error when generating for an unsupported game. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The geometry/material/LOD strategy and 'only save visible' choices made in the save dialog are stored per game in the application settings and used as the starting point for the next model saved, including in new editors and after a restart. Per-model values (output name, LOD count) still come from the model. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Routes the remaining Console.WriteLine calls in app code through the Serilog logger: per-frame bone/gizmo/selection traces at Debug, report printers and the scene graph dump at Information. Left as-is: the MeshDecimator ConsoleLogger (it is a console logger by design) and the Music end-to-end dev runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Right-click a sound or music track node in the tree to export its audio as a 16-bit PCM .wav or the raw .wem. Right-click now also selects the node under the mouse so the menu acts on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A one-frame clip was written as one dynamic frame and no static frame, which crashes the game. Surveyed ~1,600 vanilla WH3 anims: none has exactly one dynamic frame. Poses (docking, faces, hand poses, pose/) are static frame only, zero dynamic frames, 0.1s, in both v7 and v8. Write one-frame clips the same way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ming#259, donkeyProgramming#360) PFH6 index entries have the same is_compressed byte as PFH5 (RPFM reads it for both; confirmed on CA's own PFH6 _.pack from Pharaoh Dynasties). AE only read it for PFH5, so every entry in a PFH6 pack after the first was a byte off: garbage names, sizes and offsets. Likely cause of the Pharaoh cosmetic DLC models failing with 'Unknown Lod header' (garbage bytes reaching the RMV parser) and 'Unable to read beyond the end of the stream' (offsets past the end of the pack). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…egex FilterCollection built a regex before calling the custom substring filter, so a half-typed "Play_x (wh3" threw, marked the box invalid and stopped the list updating. Add an opt-in plain-text mode that skips it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A batch of fixes and small features from the open issues. One commit per issue, so each can be reviewed (or dropped) on its own.
Bug fixes
OpenWebpageCommandwent throughcmd /c start, which split paths with spaces (C:\Program Files\...). It now launches through the shell withUseShellExecute. Closes AssetEditor help menu item not launching #381//skeleton//prefix was stripped withTrimStart(chars), which also removed leading letters of the name that appear in "/skeleton", sosnake01becameake01. It now strips the prefix only. Closes Skeleton Not Found When Importing immediately exported gltf files #295MathUtil.QuaternionToEulerDegreeandEulerDegreesToQuaternionmapped the X/Y/Z fields to rotation about Y/Z/X. This affects the meta-data editor and the skeleton editor. They now mean rotation about X/Y/Z; the rotation order is unchanged. Values shown in those editors will appear under different labels than before. Adds tests. Closes ANIMATED_PROP_xx orientation error (axes X,Z) #106pose/) are static-frame only, zero dynamic frames, 0.1 s, in both v7 and v8. One-frame clips are now saved that way. Adds tests. Closes Animation Keyframe Editor does not generate Static Frames #159_.packhas it), but AE only read it for PFH5. Every entry after the first was a byte off, giving garbage names, sizes and offsets. I verified this on a real CA PFH6 pack, but not on the DLC packs from the reports; I don't have them. Issues generating lods for RMV6/ Cannot open some files related to Total War Pharaoh #360's other report (RMV6 crest LODs) isn't covered. Adds a test.Features
FilterCollectionfilter like other filterable comboboxes, with a plain substring match. Closes Update Audio Explorer search to match throughout the string not from the start #352.wavor the raw.wem. Right-click now also selects the node under the mouse. Closes Make sounds exportable #379Console.WriteLinein app code: per-frame traces at Debug, report printers and the scene graph dump at Information. The MeshDecimatorConsoleLoggerand the Music end-to-end dev runs are left as they are. Closes Ensure consistent use of AE's logger system as opposed to sometimes using Console.WriteLine(). #126Already fixed on master, can be closed
Not in this PR
Testing
The full solution builds and all tests pass. The UI changes haven't been tested by hand, and nothing has been tested in-game.
🤖 Generated with Claude Code