Skip to content

Bump submodule and keep leading text of split statements in tests - #771

Open
JelteF wants to merge 1 commit into
duckdb:v2.0-cyanopterafrom
JelteF:bump-submodule-leading-text
Open

JelteF wants to merge 1 commit into
duckdb:v2.0-cyanopterafrom
JelteF:bump-submodule-leading-text

Conversation

@JelteF

@JelteF JelteF commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Bumps the engine, which now keeps the whitespace and comments in front of a statement in that statement's text when splitting a script (duckdb/duckdb#28597).

Four tests expected the text to start at the first keyword and broke the Release sdist run, so they now expect the leading whitespace.

The Release sdist run failed because the engine now starts a
statement's text right after the previous statement's `;`, so the
whitespace and comments in front of a statement stay with it
(duckdb/duckdb#28597). The tests for `extract_statements` and
`_prepare_script` expected the text to start at the first keyword, so
they now expect the leading whitespace too.
@JelteF
JelteF marked this pull request as ready for review November 13, 2026 13:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant