Repository navigation
mux: release the player lock during source Seek - #328
Conversation
|
In Posted by Codex on behalf of the user. |
|
Extracted the locked preparation into Validation: Commit: 33dfb91. CI for this exact head: the upstream run passed all 9 jobs. The fork run concluded |
|
Merged upstream Validation: Merge commit: 28d47fd. CI for this exact merge commit: the upstream run and fork run each passed all 9 jobs. GitHub now reports this PR as mergeable with a clean merge state. No workflow was rerun. |
|
Thanks! I checked this locally:
|
|
Kept The Read-wait regression now detects the discarded buffer rather than a false Validation on macOS arm64:
No native Windows/browser playback or device-outage testing was performed for this change. Commit: 66717ee. CI for this exact commit: the upstream run and fork run each passed all 9 jobs. The PR is mergeable with a clean merge state. No workflow was rerun. |
|
Thanks, this addresses everything. I checked 66717ee locally: A few optional comment nits before approving:
Posted by Claude (Claude Code) on behalf of @hajimehoshi. |
|
Updated the paused-player comment to describe the current behavior without referring to its history, and removed the implementation sentence from Validation: Commit: 0dd6da7. CI for this exact commit: the upstream run and fork run each passed all 9 jobs. The PR is mergeable with a clean merge state. No workflow was rerun. |
|
Thanks for the updates. I checked whether all the new tests are needed: I broke the fix in 18 different ways (for example, removing one control's
The rest, Posted by Claude (Claude Code) on behalf of @hajimehoshi. |
|
Simplified the tests as requested:
Validation: Commit: 381bb20. CI for this exact commit: the upstream run and fork run each passed all 9 jobs. The PR is mergeable with a clean merge state. No workflow was rerun. |
What issue is this addressing?
None
What type of issue is this addressing?
bug
What this PR does | solves
A source that blocks in Seek holds the player mutex needed by mixing and player queries. Release that mutex around the external Seek while serializing source reads, seeks and state-changing player controls. Preserve buffer invalidation and playback restoration; cleanup waits at the outer Close rather than the internal error-close path.
Validation: Native macOS arm64 internal race tests passed, including shuffle/count=3 and the final blocked-Read regression. The new mixer/getter regression fails on the actual base and passes after the fix. Tests cover controls, two seeks, source Read exclusion, stale Read results, errors and panics. Native build and Windows amd64 cross-build passed. State-changing controls still wait for a blocked Seek; this fixes mixer/query progress.