Skip to content

ci: packaged programmer at @v1, built with the esptool version this build used - #7

Merged
finger563 merged 1 commit into
mainfrom
chore/packaged-programmer-v1
Nov 6, 2026
Merged

finger563 merged 1 commit into
mainfrom
chore/packaged-programmer-v1

Conversation

@finger563

Copy link
Copy Markdown
Contributor

Summary

The packaging workflow follows esp-cpp/esp-packaged-programmer-action at @v1, which tracks releases without a change here each time, and hands it the esptool version the build used, which the action now packages (esp-cpp/esp-packaged-programmer-action#7): the flash arguments ESP-IDF generates into flasher_args.json and flash_args follow the esptool it builds with (ESP-IDF 6.x uses esptool 5.x, whose options are spelled with dashes), so the packaged programmer must carry the same one. The build step records it with one extra command (python -m esptool version | tail -1 > build/esptool_version.txt) and the file travels in the build artifact; the action reads it from there.

Test plan

  • Workflow parses
  • The next push to main runs it: the build log shows the recorded version, the package jobs print "esptool version from build/esptool_version.txt in the zipfile" and package that esptool

🤖 Generated with Claude Code

https://claude.ai/code/session_01DFjjnq3XCTRAXENSxsCxJU

…uild used

The packaging action follows its @v1 tag now (tracks releases without a
change here each time) and packages the esptool version the build used
(esp-cpp/esp-packaged-programmer-action#7): the flash arguments ESP-IDF
generates follow the esptool it builds with, so the programmer must carry
the same one. The build step records it into build/esptool_version.txt
and the file travels in the build artifact, where the action reads it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DFjjnq3XCTRAXENSxsCxJU
Copilot AI balanced review requested due to automatic review settings November 6, 2026 16:01
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

✅Static analysis result - no issues found! ✅

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the packaging update that uses the build’s esptool version.

No open issues 🎉

What changed in this PR

Updates programmer packaging to use the build’s esptool version, keeping the packaged tool compatible with ESP-IDF’s generated flash arguments.

Changes:

  • Records the esptool version after a successful build.
  • Includes build/esptool_version.txt in the build artifact for the packaging action to consume.
  • Switches the packaging action from @v1.0.5 to the moving @v1 release tag.
File Description
.github/​workflows/​package_main.yml Passes the build’s esptool version through the artifact and updates the packaging action reference.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

ESP-IDF Size Report for 'Template'

Metric Base PR Delta
FLASH 306,590 bytes (20.44%) 306,590 bytes (20.44%) 0 bytes (0.00%)
DRAM 17,604 bytes (9.74%) 17,604 bytes (9.74%) 0 bytes (0.00%)
IRAM 42,295 bytes (32.27%) 42,295 bytes (32.27%) 0 bytes (0.00%)
RAM (DRAM+IRAM) 59,899 bytes 59,899 bytes 0 bytes (0.00%)

FLASH uses app .bin size or json2 flash sum. RAM sums DRAM+IRAM via idf_size. Percentages shown when totals are available.
DRAM/IRAM usage does not include memory used by the heap allocator at runtime.
This report was generated by esp-idf-size-delta.

@finger563
finger563 merged commit 0c99eab into main Nov 6, 2026
3 checks passed
@finger563
finger563 deleted the chore/packaged-programmer-v1 branch November 6, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants