Repository navigation
Version 0.11.1: the spec at API 1.21.2 - #20
Merged
Merged
Conversation
The saved spec follows the public document at API 1.21.2, merged three ways from 1.21.0. All 5 changes applied with no conflict, and every earlier local edit is kept. Subscription.cancel_at and Subscription.ends_at stay out of required, as the README asks for new response fields. The models are regenerated, 175 as before. OneTimeConfirmSummary.state gains link_canceled. ConflictError.reason reads details.reason, which a second checkout of the plan sends. The docstrings of both clients name the 409 of the checkout and the end of a subscription. Four new tests cover the new surface. The README and the CHANGELOG say what changed.
The saved spec takes the public document of faxforagents/openapi#18 at its second commit. Its 409 of confirm_one_time_order names link_canceled, which the server answers since 1.21.2. The models are the same. The confirm docstring of both clients names the code. Its first line is reworded for the writing lint. The link_canceled test also covers a confirm of that link.
The changelog said only that it is null while the plan renews. The server also sends null after the plan ended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client follows API 1.21.2, released on 2026-11-16 (build
c2058a39). The saved spec was merged from the public document of faxforagents/openapi#18, which is not merged yet.What a caller can notice
Subscription.cancel_atandSubscription.ends_at.cancel_atis when Stripe is set to end the subscription, which a cancel in the billing portal sets.ends_atis when the plan ends without another charge,Nonewhile it renews.OneTimeConfirmSummary.stateacceptslink_canceled, the confirm link of an order that was canceled. On it,read_by_tokenandget_by_tokenof 0.11.0 raise pydantic'sValidationError.ConflictError.reasonreadsdetails["reason"], asConflictError.statereadsdetails["state"]. A secondbilling.create_subscription_checkoutraisesConflictErrorwithplan_activeorcheckout_open. Withcheckout_open,details["url"]is the open payment page anddetails["expires_at"]is when it closes.billing.create_subscription_checkoutnames its 409, andbilling.list_subscriptionsnamescancel_atandends_at, on both clients.one_time_sends.confirmnames the 409link_canceled, the answer for the link of a canceled order since API 1.21.2. The public document names it since the second commit of Take the document at API version 1.21.2 openapi#18, which this pull request follows in its own second commit.New fields, a new accepted value and a new property, so the version is 0.11.1. No method or argument changed, and nothing public is removed.
How the spec was refreshed
The public document at 1.21.0 was the base of a three-way merge with the saved spec, done on the parsed documents. Its 5 changes applied with no conflict, and every earlier local edit is kept. The merge script reproduces the merge of 0.11.0 byte for byte from its inputs, and reports the 16 changes that pull request named. The result was written in the style of
scripts/curate.py.One local edit is new. The public document requires
Subscription.cancel_atandSubscription.ends_at, and the saved spec leaves both out ofrequired, as the README asks for new response fields. Apart from that and the header line, the diff of the saved spec equals the diff of the public document. The saved spec has 165 operations and 175 schemas, the same sets as the public document.python scripts/gen_models.pywrote the models: no model is new, 175 in all.The shared fixtures hold no subscription and no confirm summary in the new state, so they are unchanged. The new tests build the subscription from
sub_jsonofbilling/subscriptions.pyatc2058a39, and the 409 fromrefuse_second_checkoutin the same file.Checked
pytest -q -m "not live": 199 pass, 4 of them new. The live test was not run, since it needs a test key.ruff check src tests,ruff format --check src tests,mypy src,python scripts/gen_models.py --checkandsh scripts/truthcheck.shpass.python -m buildandtwine check --strictpass. The wheel with[cli]installs in a clean venv.faxforagents versionprints 0.11.1, andfaxforagents.modelshas 175 names.confirmdocstring. It now reads "It takes no API key." The generatedOneTimeOrderdocstring now passes too, since the public document split its long sentence.No workflow file changed. Nothing is merged, tagged, released or published by this pull request.